Add Support for Python 3.12 and drop Python 2 Support #18
Conversation
|
@pbauer thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", |
There was a problem hiding this comment.
I would declare support for Python >= 3.8.
But this is a really minor detail.
There was a problem hiding this comment.
I will merge the PR, and then remove the 3.6 and 3.7 classifiers.
|
@jenkins-plone-org please run jobs Of course I expect the Py 2.7 jobs to fail, let's see |
plone/reload/xreload.py
Outdated
| import zope.component | ||
|
|
||
| # from zope.interface.interface import Specification |
There was a problem hiding this comment.
| # from zope.interface.interface import Specification |
|
I have released |
I'm not really sure about the main changes in the
Reloaderclass. It seems to work as well as before (i.e. schema-changes are not applied but it works fine for for stuff like views and services). Maybe the whole thing could use a rewrite but I'm fine with what it does so far.